Fix get icon #156
Open
Fix get icon #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In larger applications with multiple assemblies, entry assembly may be null.
This will cause issues when trying to display an
AcrylicWindowfor example, which uses theAppIcon.(Even when
AcrylicWindowStyleis set toNoIcon/None)The reason I used
Assembly#GetExecutingAssemblyover Assembly#GetCallingAssemblycan be found here.It does not matter in my case but it may in someone elses.
The fix is also written in a way that will not affect other programs, only if the EntryAssembly returns null, it will get the ExecutingAssembly.
Related Issue
Resolves #87
Extra
I also removed the using statements that were not in use.