-
Notifications
You must be signed in to change notification settings - Fork 12
Introduce a convenience shortcode to link to keywords #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Agnivesh Chaubey <agniveshvapi@gmail.com>
Oops! I missed that. Actually I intentionally converted them to lowercase, basause the URL was not working with camelCase words. I'll make a copy of the keyword before converting it to lowercase in order to preserve its case during render. |
Signed-off-by: Agnivesh Chaubey <agniveshvapi@gmail.com>
What do you think about mentioning the vocabulary? Does it feel OK to you, or is it too much? |
I'd say let's avoid mentioning vocabulary along with keywords. If we really wanna include it, one thing we can do is include the vocabulary name inside a tool tip. |
Sounds good. Let's do that then |
Signed-off-by: Agnivesh Chaubey <agniveshvapi@gmail.com>
The latest changes should show the vocabulary name inside a tootip. I wasnt able to test that because not sure why all of a sudden I started getting the following error:
I tried deleting node_modules and package-lock.json and then reinstalled them to make sure all the dependencies ware present, but the error still persists. The changes should show the tooltip as expected. Just give a confirmation for that so that slowly I can start replacing all the keyword occurances with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Looks great! Let's get this one merged and feel free to send more PRs incrementally updating things everywhere. Small PRs per keyword are probably better than a big one. I'm doing various updates to the site, so it will help avoiding potential conflicts.
I have extended the shortcode to accept two more arguments ('vocabulary' and 'dialect'), with 'dialect' being optional. @jviotti, the link you provided here for the
ref
shortcode seems to be broken, and with quick googling, I couldn't find a way to use one shortcode inside another.BTW, I'm not sure if we need to use the
ref
shortcode here, as hugo by default returns a "Page Not Found" response when it cant find the page.