Add new resource: network_interfaces_eni #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbyrnes
force-pushed
the
add-network_interfaces_eni
branch
from
75ce557 to
9665281
Compare
Uses the aws-sdk gem, added as a dependency to metadata
jeffbyrnes
force-pushed
the
add-network_interfaces_eni
branch
from
9665281 to
79d2acd
Compare
jeffbyrnes
added
Feature Request
bmhughes
reviewed
Jun 29, 2021
bmhughes
left a comment
bmhughes
left a comment
There was a problem hiding this comment.
One small recommendation, other than that looks good!
| end | ||
| end | ||
|
|
||
| private |
There was a problem hiding this comment.
All these can be added to the action_class block rather than adding them to the 'outer' resource class.
There was a problem hiding this comment.
Contributor
Author
|
Oh and it wants a rebase on main too. |
xorima
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
aws-sdkgem, added as a dependency to metadataThis is some older work that @eherot did, I’ve rebased it & stacked it up here for perusal by all.