CI: test --editable installation #602
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged as is, it is just meant to illustrate that editable installations are broken.
I'm not sure what happened and when that happened, but I think it did work in the past. However, the problem is easy to miss if you once run
sounddevice_build.pymanually, because this will create the file_sounddevice.py, and if you don't delete that manually, it will hide the problem.I don't know if this is a problem with CFFI, or if our usage is wrong.
As a short-term work-around, I think I'll add to the installation instructions that
sounddevice_build.pyhas to be executed manually for now.If this is fixed at some point, we should add a regression test.