feat: add checker for role with extra backtick #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mattwang44
force-pushed
the
fix-#64-extra-backtick
branch
from
e11461f to
a807742
Compare
|
Opened pandas-dev/pandas#62845 |
|
Yay! |
|
Released as 1.0.1. |
|
Nice, thank you! |
Closed
|
Thanks for the release! Tip for the next release: we have Trusted Publishing set up for this repo so can follow the steps at https://github.com/sphinx-contrib/sphinx-lint#releasing which gives us release notes and it also sends notifications to people watching the repo. Also, do we use SemVer here? if so, adding a feature release can be a minor bump next time (like 1.1.0 rather than 1.0.1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #64
The only failed case of pandas doc is expected (this GitHub search link lists the roles with extra backtick in pandas doc).If this PR looks legit, I'll send a PR to pandas.updated: I've sent a PR to pandas, and it has been merged.