Simplify fixture in tests/test_extensions/test_ext_apidoc.py by removing unused return value #13695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing unused return value
|
I chose to do this rather than add type hints to |
AA-Turner
requested changes
Jun 24, 2025
| @@ -37,16 +37,13 @@ def apidoc(rootdir, tmp_path, apidoc_params): | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def apidoc_params(request): | |||
There was a problem hiding this comment.
This is currently in line with app_params(), perhaps worth maintaining the pattern?
There was a problem hiding this comment.
As in just ditch this PR? I'm OK to do that
AA-Turner
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pargswas being calculated and returned but never used.