Solve issues #177 and #178 #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
What does your new setting do? You do not override templates, but existing pages. Therefore I do not yet understand the setting name. Please note that the setting text is still missing in the configuration manager. ps: could you please describe the real change your are performing in a commit, instead of mentioning the file name. In the future that is more helpful if someone is reading back the changes that occur in that file. Thanks! |
Author
|
My idea was: A page will be overwritten with the content of the template. But this may be misleading. How is "pageoverwrite"? I also added the description of the option. |
Author
|
I renamed the option templateoverwrite to pageoverwrite. Now there is probably no ambiguity any more. |
|
This actually does not solve #177 at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #177 and #178.