Add default for :socket_path option
#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…descriptive error if socket_path is not provided
Collaborator
|
Love the options handling for both maps and Keywords, the keywords part was already done in #17 |
Base automatically changed from
update_sdk_function_signatures
to
development
February 6, 2025 22:20
EmilianoSanchez
changed the title
:socket_path option:socket_path option
gthea
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:socket_pathoption (/var/run/splitd.sock), instead of throwing an error if not provided, for consistency with other thin clients, like the PHP one.@specof functions.