Added old spec support in splitfetcher #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanzmauro
requested changes
Apr 22, 2025
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
sanzmauro
requested changes
Apr 23, 2025
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/dtos/SplitChangesOldPayloadDto.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
gthea
reviewed
Apr 23, 2025
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
…adDto.java Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
Co-authored-by: gthea <theagaston@gmail.com>
sanzmauro
reviewed
Apr 25, 2025
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
chillaq
changed the base branch from
rbs-localhost
to
feature/rule-based-segment
…-client into rbs-oldspec-fetcher
sanzmauro
approved these changes
Apr 28, 2025
Contributor
sanzmauro
left a comment
sanzmauro
left a comment
There was a problem hiding this comment.
I left some suggestions.
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/client/HttpSplitChangeFetcher.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.