Skip to content

Conversation

JensAyton
Copy link
Contributor

Alternative to #114 .

The downside of this approach is that there are now four overloads of Mobius.loop, which could get nasty if we want to add more dimensions of variants, or just change the interface (for instance, using defaulted arguments instead of the three remaining with functions).

I prefer this approach if we view the explicit Connectable approach as transitional. If we want to keep all the variants forever, I lean towards #114 .

@jeppes @rastersize

@jeppes
Copy link
Contributor

jeppes commented Feb 18, 2020

Hmm, I'm not sure about this. I think there are good arguments for both.
Any thoughts, @pettermahlen?

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.03%. Comparing base (a68b568) to head (ccf05d0).
⚠️ Report is 181 commits behind head on master.

Files with missing lines Patch % Lines
MobiusCore/Source/Mobius.swift 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   92.30%   92.03%   -0.27%     
==========================================
  Files          46       46              
  Lines        1442     1456      +14     
==========================================
+ Hits         1331     1340       +9     
- Misses        111      116       +5     
Flag Coverage Δ
ios 92.03% <70.58%> (-0.27%) ⬇️
macspm 92.03% <70.58%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rastersize
Copy link
Contributor

I missed reviewing this one I think. I’m personally in favor of this approach and eventually removing the Connectable variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants