Upgrade Nimble (and min SDK versions) #217
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dflems
commented
Aug 21, 2025
| .iOS(.v13), | ||
| .macOS(.v10_15), | ||
| .tvOS(.v13), | ||
| .watchOS(.v6), |
There was a problem hiding this comment.
Nimble complained about some of these. Probably about time to bump anyway? iOS 10 is mighty old.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 43 43
Lines 1460 1460
=======================================
Hits 1404 1404
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dflems
commented
Aug 22, 2025
| dependencies: [ | ||
| .package(url: "https://github.com/pointfreeco/swift-case-paths", .upToNextMinor(from: "0.10.1")), | ||
| .package(url: "https://github.com/Quick/Nimble", from: "10.0.0"), | ||
| .package(url: "https://github.com/Quick/Nimble", from: "11.0.0"), |
There was a problem hiding this comment.
Will followup w/ an upgrade to 13.x, this is a baby step
zvonicek
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nimble.Predicatehas becomeNimble.Matcher. Other than that, Nimble seems happy.Also bumps the min SDK version to match latest Nimble.