Skip to content

feat: Local resolve uses new state url endpoint #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabriziodemaria merged 2 commits into from
Oct 13, 2025
Merged

feat: Local resolve uses new state url endpoint #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c7141
feat: Local resolve uses new state url endpoint
fabriziodemaria Oct 10, 2025
0235b39
feat: Shade the new proto
fabriziodemaria Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions confidence-proto/src/main/proto/confidence/flags/admin/v1/resolver.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,52 +4,14 @@ package confidence.flags.admin.v1;

import "google/protobuf/timestamp.proto";
import "google/api/resource.proto";
import "google/api/annotations.proto";
import "confidence/iam/iam.proto";
import "google/api/field_behavior.proto";

import "confidence/flags/admin/v1/types.proto";

option java_package = "com.spotify.confidence.shaded.flags.admin.v1";
option java_multiple_files = true;
option java_outer_classname = "ResolverProto";

// Service for fetching the state for resolving flags
service ResolverStateService {
// Gets the full state for running a resolver
rpc FullResolverState(ResolverStateRequest) returns (stream ResolverState) {
option (google.api.http) = {
get: "/v1/resolverState:full"
};
}

// Gets a signed uri that can be used to download the current resolver state
rpc ResolverStateUri(ResolverStateUriRequest) returns (ResolverStateUriResponse){
option (google.api.http) = {
get: "/v1/resolverState:resolverStateUri"
};
}
}

// Request to fetch resolver state uri
message ResolverStateUriRequest {

}

// Response of fetching resolver state uri
message ResolverStateUriResponse {
// The signed uri that can be used to fetch state
string signed_uri = 1;
// At what time the state uri expires
google.protobuf.Timestamp expire_time = 2;
string account = 3;

}

// Request to get the resolver state for the whole account
message ResolverStateRequest {
}

// The full state for operating a flags resolver
message ResolverState {
// All active flags
Expand Down
31 changes: 31 additions & 0 deletions confidence-proto/src/main/proto/confidence/flags/resolver/v1/resolver.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
syntax = "proto3";

package confidence.flags.resolver.v1;

import "google/protobuf/timestamp.proto";

option java_package = "com.spotify.confidence.shaded.flags.resolver.v1";
option java_multiple_files = true;
option java_outer_classname = "ResolverStateProto";

// Service for fetching resolver state metadata (e.g., a signed URI to the state file)
service ResolverStateService {
// Gets a signed uri that can be used to download the current resolver state
rpc ResolverStateUri(ResolverStateUriRequest) returns (ResolverStateUriResponse) {
}
}

// Request to fetch resolver state uri
message ResolverStateUriRequest {}

// Response of fetching resolver state uri
message ResolverStateUriResponse {
// The signed uri that can be used to fetch state
string signed_uri = 1;
// At what time the state uri expires
google.protobuf.Timestamp expire_time = 2;
// The account the referenced state belongs to
string account = 3;
}


6 changes: 3 additions & 3 deletions openfeature-provider-local/src/main/java/com/spotify/confidence/FlagsAdminStateFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
import com.google.protobuf.ByteString;
import com.google.protobuf.Timestamp;
import com.spotify.confidence.shaded.flags.admin.v1.Flag;
import com.spotify.confidence.shaded.flags.admin.v1.ResolverStateServiceGrpc;
import com.spotify.confidence.shaded.flags.admin.v1.ResolverStateUriRequest;
import com.spotify.confidence.shaded.flags.admin.v1.ResolverStateUriResponse;
import com.spotify.confidence.shaded.flags.admin.v1.Segment;
import com.spotify.confidence.shaded.flags.resolver.v1.ResolverStateServiceGrpc;
import com.spotify.confidence.shaded.flags.resolver.v1.ResolverStateUriRequest;
import com.spotify.confidence.shaded.flags.resolver.v1.ResolverStateUriResponse;
import com.spotify.confidence.shaded.iam.v1.Client;
import com.spotify.confidence.shaded.iam.v1.ClientCredential;
import io.grpc.health.v1.HealthCheckResponse;
Expand Down
4 changes: 2 additions & 2 deletions ...ture-provider-local/src/main/java/com/spotify/confidence/LocalResolverServiceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
import com.google.protobuf.Struct;
import com.spotify.confidence.TokenHolder.Token;
import com.spotify.confidence.shaded.flags.admin.v1.FlagAdminServiceGrpc;
import com.spotify.confidence.shaded.flags.admin.v1.ResolverStateServiceGrpc;
import com.spotify.confidence.shaded.flags.admin.v1.ResolverStateServiceGrpc.ResolverStateServiceBlockingStub;
import com.spotify.confidence.shaded.flags.resolver.v1.InternalFlagLoggerServiceGrpc;
import com.spotify.confidence.shaded.flags.resolver.v1.ResolverStateServiceGrpc;
import com.spotify.confidence.shaded.flags.resolver.v1.ResolverStateServiceGrpc.ResolverStateServiceBlockingStub;
import com.spotify.confidence.shaded.flags.resolver.v1.Sdk;
import com.spotify.confidence.shaded.flags.resolver.v1.WriteFlagLogsResponse;
import com.spotify.confidence.shaded.iam.v1.AuthServiceGrpc;
Expand Down