Polish tests #42725
Closed
Polish tests #42725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quaff
commented
Oct 17, 2024
quaff
commented
- Improve null safety
- Replace lambda with method reference
1. Improve null safety 2. Replace lambda with method reference
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
added
type: task
wilkinsona
requested changes
Oct 17, 2024
| void getWhenHasValidatedBeanBindsWithBeanAnnotation() throws Throwable { | ||
| get(ValidatedBeanConfiguration.class, "validatedBean", (propertiesBean) -> { | ||
| Validated validated = propertiesBean.asBindTarget().getAnnotation(Validated.class); | ||
| assertThat(validated).isNotNull(); |
Member
There was a problem hiding this comment.
I don't think this is an improvement. It makes the test more verbose and I think the benefit is negligible. Should validated be null, the NPE that would occur on the next line when calling validated.value() will make that clear.
Contributor
Author
There was a problem hiding this comment.
It makes IDEA and code analysis tools happy, is it worthy?
| void getWhenHasValidatedFactoryMethodBindsWithFactoryMethodAnnotation() throws Throwable { | ||
| get(ValidatedMethodConfiguration.class, "annotatedBean", (propertiesBean) -> { | ||
| Validated validated = propertiesBean.asBindTarget().getAnnotation(Validated.class); | ||
| assertThat(validated).isNotNull(); |
| void getWhenHasValidatedBeanAndFactoryMethodBindsWithFactoryMethodAnnotation() throws Throwable { | ||
| get(ValidatedMethodAndBeanConfiguration.class, "validatedBean", (propertiesBean) -> { | ||
| Validated validated = propertiesBean.asBindTarget().getAnnotation(Validated.class); | ||
| assertThat(validated).isNotNull(); |
| ApplicationContext applicationContext = new AnnotationConfigApplicationContext(Example.class); | ||
| ConfigurationPropertiesBean bean = ConfigurationPropertiesBean.get(applicationContext, | ||
| applicationContext.getBean(Example.class), "example"); | ||
| assertThat(bean).isNotNull(); |
Member
There was a problem hiding this comment.
As above. Please revert. Additionally, getBean(Class) will never return null, throwing a NoSuchBeanDefinitionException instead.
Contributor
Author
There was a problem hiding this comment.
ConfigurationPropertiesBean.get() is @Nullable
Member
There was a problem hiding this comment.
Sorry, I misread the diff. Regardless, the same reasoning as above still applies. I don't think null checks such as this in tests are beneficial.
| void boundPropertiesShouldBeRecorded() { | ||
| load(NestedConfiguration.class, "name=foo", "nested.name=bar"); | ||
| BoundConfigurationProperties bound = BoundConfigurationProperties.get(this.context); | ||
| assertThat(bound).isNotNull(); |
wilkinsona
pushed a commit
that referenced
this pull request
Oct 18, 2024
Replace lambdas with method references See gh-42725
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.