Add isNotEmpty Utility Methods to Improve Readability and Safety #35247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddeepak
commented
Jul 28, 2025
| public static boolean isNotEmpty(@Nullable Map<?, ? extends @Nullable Object> map) { | ||
| return (map != null && !map.isEmpty()); | ||
| } | ||
|
|
There was a problem hiding this comment.
@mdeinum
Added isNotEmpty methods to CollectionUtils as suggested to improve readability and avoid !isEmpty() usage
spring-projects-issues
added
the
status: waiting-for-triage
iddeepak
commented
Jul 28, 2025
| @@ -244,7 +244,7 @@ else if (ch == '"') { | |||
| nextIndex++; | |||
| } | |||
| String parameter = mimeType.substring(index + 1, nextIndex).trim(); | |||
| if (parameter.length() > 0) { | |||
| if (StringUtils.hasLength(parameter)) { | |||
There was a problem hiding this comment.
use StringUtils already has a way to check
@mdeinum
|
I see StringUtils#isEmpty is replaced with !StringUtils.hasLength everywhere, Can't we just use if string.isEmpty() ? |
|
Thanks for the proposal, but this has been declined multiple times, see #34519 and linked issues. |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces new utility methods to improve readability and reduce the risk of subtle bugs related to negated emptiness checks:
Adds CollectionUtils.isNotEmpty(Collection) Adds CollectionUtils.isNotEmpty(Map)
Motivation
As noted by @mdeinum in #35243 , negated expressions like !collection.isEmpty() can be error-prone: