Skip to content

Optimize single-char wildcard path matching performance #36095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
playous wants to merge 1 commit into from
+5 −2
Closed

Optimize single-char wildcard path matching performance #36095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...b/src/main/java/org/springframework/web/util/pattern/SingleCharWildcardedPathElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,11 @@ public boolean matches(int pathIndex, MatchingContext matchingContext) {
else {
for (int i = 0; i < this.len; i++) {
char ch = this.text[i];
// TODO revisit performance if doing a lot of case insensitive matching
if ((ch != '?') && (ch != Character.toLowerCase(value.charAt(i)))) {
char valCh = value.charAt(i);
if (ch == valCh || ch == '?') {
continue;
}
if (ch != Character.toLowerCase(valCh)) {
return false;
}
}
Expand Down