-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add ExpressionTemplateValueProvider #17448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExpressionTemplateValueProvider #17448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mheath, for the PR! It's nice to hear from you again. I've left some feedback inline.
...ringframework/security/core/annotation/ExpressionTemplateSecurityAnnotationScannerTests.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/core/annotation/ExpressionTemplateValueProvider.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/core/annotation/ExpressionTemplateValueProvider.java
Show resolved
Hide resolved
Hey Josh. Thanks for taking a look at my PR. It's been too long. We need to catch up sometime in more than just PR comments! |
89988e4
to
ca58ca9
Compare
Thanks for the updates, @mheath. Are you able to sign your commit? (Note that I rebased, squashed, and added a polish commit before I noticed. Apologies, you may need to reset in order to push a change to your commit message.) |
ca58ca9
to
cff5653
Compare
Yep. My commit is signed. |
This is what the CI sees:
![]() In addition to the title and the reference to the ticket number, the commit message should say something like:
I'm not sure why the commit in the PR doesn't have that. I'm sure you are already familiar, but just for easy reference, here is where GitHub reviews the DCO process. |
Closes spring-projectsgh-17447 Signed-off-by: Mike Heath <michael.heath@familysearch.org>
Issue spring-projectsgh-17447 Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
cff5653
to
6c3ac8c
Compare
Oops. I forgot that --gpg-sign doesn't add the DCO line. It's there now. |
Excellent, @mheath. This will merge once the build completes. Thanks again! |
Implements a simple mechanism for providing custom expression template values from enums used in expression templates.
Closes gh-17447