Skip to content

fix: updates compiled design tokens Sass variable names #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2023
Merged

fix: updates compiled design tokens Sass variable names #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06be654
fix: updates compiled design tokens Sass variable names
sturobson Jan 10, 2023
39a2c74
corrects mis-duplciation of the dollar sign
sturobson Jan 10, 2023
b15e666
Merge branch 'main' into fix/sass-variable-naming
sturobson Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions context/brand-context/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# History

## 31.0.1 (2023-01-10)
* FIX: updates the block spacing variable naming to use the correct token variable.
## 31.0.0 (2023-01-04)
* Reduce scope of block spacing
* NOTE: This version replaces all versions >= 28.0.0
Expand Down
4 changes: 2 additions & 2 deletions context/brand-context/default/scss/40-base/block-spacing.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ h1, h2, h3, h4, h5 {
// The specificity is that of one element selector.
:is(p, ol, ul, dl, figure, blockquote, form, pre, table, img, video, aside, section, article) +
:is(p, ol, ul, dl, figure, blockquote, form, pre, table, img, video, aside, section, article) {
margin-block-start: $tokens--typography-block-spacing-medium;
margin-block-start: $t-typography-block-spacing-medium;
}

// <div> elements found among basic semantic content likely need similar margin applied.
// The specificity is that of two element selectors; a utility class can override it
:is(p, ol, ul, dl, figure, blockquote, pre, table, img, video) + div,
div + :is(p, ol, ul, dl, figure, blockquote, pre, table, img, video) {
margin-block-start: $tokens--typography-block-spacing-medium;
margin-block-start: $t-typography-block-spacing-medium;
}

// Headings have differing margins to other flow elements.
Expand Down
2 changes: 1 addition & 1 deletion context/brand-context/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@springernature/brand-context",
"version": "31.0.0",
"version": "31.0.1",
"license": "MIT",
"description": "Bootstrapping for all components and products",
"keywords": [],
Expand Down