Feature/fargate #35
Draft
Feature/fargate #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor ExecFargate for KISS/DRY compliance: * Extract helper functions (trySSMParent, tryDirectExecution, etc.) * Replace boolean flags with execResult struct * Reduce ExecFargate from ~180 lines to ~20 lines * Improve error handling and readability - Fix container name handling in exec command: * Add validation when container_name flag is not provided * Ensure command is not empty after container name extraction * Provide clear error messages for invalid usage - Remove debug print statement from cmd/run.go - Fix redundant string wrapping in lib/runFargate.go: * Remove unnecessary aws.String()/aws.StringValue() wrapping * Use strings directly in log fields - Add documentation comment about public IP usage in Fargate * Note that IPv6 implementation will change this behavior - Fix linter warnings and improve code consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.