refactor: Extract Contracts from discoverer and allow clients to supply their own #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boblail
force-pushed
the
lail/contracts
branch
5 times, most recently
from
9d1c2da to
8b9773c
Compare
boblail
force-pushed
the
lail/contracts
branch
from
8b9773c to
9e53a8e
Compare
boblail
commented
Dec 30, 2025
Comment on lines
+35
to
+41
| buffer := make([]byte, 2) | ||
| if _, err := f.Read(buffer); err != nil { | ||
| return nil, err | ||
| } | ||
| if string(buffer) != "#!" { | ||
| return nil, ErrNotApplicable // Not a shell script | ||
| } |
Member
Author
There was a problem hiding this comment.
👀 This is a behavior change.
We're opening shell scripts more eagerly — during discovery (which adds an up-front cost to every execution) rather than only when needing summary (such as when rendering a menu of commands).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the most part, this splits some procedural logic in
discovery.gointo four contracts that are tested in order. These are:DirectoryContractExecutableContract.exoskeletonand responds to--describe-commandsShellScriptContractStandaloneExecutableContract--summaryThis refactor does two things:
There is one (known) behavioral change: the first to bytes of executables are read eagerly. This incurs a cost of 80µs per command (or 19ms for 240 commands) — so far I'm not concerned.