-
Notifications
You must be signed in to change notification settings - Fork 6
Torch/TorchGeo Export & Packaging #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torch/TorchGeo Export & Packaging #97
Conversation
5d60f73
to
ac35306
Compare
ac35306
to
d47dde3
Compare
@rbavery @isaaccorley |
I think your reasoning makes sense on keeping the validation path the same whether it is done with pydantic or pystac, and accommodating more complex references to other stac extensions. the extra tabs/spaces and extra field is a bit unfortunate for the use cases that don't need these more complex references but probably worth it. |
I've updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is looks pretty good and almost ready to merge.
Just waiting on remaining threads to be resolved to proceed.
198e7cf
to
2c7961f
Compare
Co-authored-by: Ryan Avery <ryanbarryavery@gmail.com>
Co-authored-by: Ryan Avery <ryanbarryavery@gmail.com>
Note: |
a29f4ca
to
d2bc5ed
Compare
Description
This PR adds functions for exporting and packaging a torch (in this example, TorchGeo) model and transforms along with model metadata that is compliant with the MLM schema into a single
.pt2
archive.This currently depends on the torch 2.8 pre-release of PyTorch scheduled to be released early next month.
Related Issue
N/A
Type of Change
Checklist
CONTRIBUTING.md
guide;CHANGELOG.md
with provided changes;README.md
and/orbest-practices.md
as applicable with new features;make check
;Google
format for all the methods and classes that I used.