Skip to content
This repository was archived by the owner on Jun 2, 2024. It is now read-only.

Conversation

GuillaumeFalourd
Copy link
Contributor

@GuillaumeFalourd GuillaumeFalourd commented Jan 20, 2023

Signed-off-by: Guillaume Falourd guillaume.falourd@zup.com.br

  • add connection-interface schema.
  • add aws-ecs-conn connection interface type.
  • add aws-rds-conn connection interface type.

Related to https://github.com/stack-spot/runtime-engine-api/issues/30

Other types could be created following https://github.com/orgs/terraform-aws-modules/repositories specifications.

Signed-off-by: Guillaume Falourd <guillaume.falourd@zup.com.br>
@GuillaumeFalourd GuillaumeFalourd self-assigned this Jan 20, 2023
type: aws-ecs-conn
outputs:
- name: autoscaling_capacity_providers
type: json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamos realmente ter atributos complexos (object e list)? Se for ter não deveríamos descrever quais são os atributos desses objetos complexos?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillaumeFalourd algum atualização ?

"type": {
"type": "string",
"enum": [
"aws-ecs-conn",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

como vamos trabalhar a questao de novos tipos? geramos uma nova versao?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillaumeFalourd algum atualização ?

Signed-off-by: Guillaume Falourd <guillaume.falourd@zup.com.br>
Signed-off-by: Guillaume Falourd <guillaume.falourd@zup.com.br>
Signed-off-by: Guillaume Falourd <guillaume.falourd@zup.com.br>
schemaVersion: v1
kind: connection-interface
metadata:
name: AWS RDS CONNECTION INTERFACE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho q o name e o display name estão invertidos.
A ideia do name é o que exibiria no CLI ou o usuário digitaria via linha de comando.
O Display name seria algo mais friendly pra exibição em telas.

O name no caso tb acaba fazendo um papel de slug, caso seja necessário o usuário final referenciar escrevendo.

"type": {
"type": "string",
"enum": [
"null",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o q seria um type do tipo null?

version: 1.0.0
picture: connection.png
spec:
type: aws-ecs-conn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O Type seria um enum fixo?
Ou o type já poderia ser o name do connection interface?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants