Replace 2024.1 upper constraint with 2025.1 #71

MaxBed4d · 2025-10-03T09:38:57Z

Simple update of the upper constraint file from 2024.1 to 2025.1

gemini-code-assist · 2025-10-03T09:39:14Z

Summary of Changes

Hello @MaxBed4d, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to synchronize the project's Python dependency management with the latest OpenStack release cycle. By updating the upper constraints file to 2025.1, it ensures that all related Ansible roles and their associated Python environments will install dependencies that are compatible with the most recent stable OpenStack release, promoting stability and access to the latest features and bug fixes.

Highlights

Dependency Constraints Update: The pull request updates the OpenStack upper constraints file version from 2024.1 to 2025.1 across multiple Ansible roles.
Scope of Change: This change affects the default configuration for os_container_clusters, os_deploy_templates, os_images, os_networks, os_openstackclient, os_openstacksdk, os_projects, os_ratings, and os_volumes roles, as well as an example in the os_projects README.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly updates the OpenStack upper constraints version from 2024.1 to 2025.1 across multiple roles. My review focuses on improving maintainability by addressing the repeated hardcoding of the constraints URL. I've suggested using a common Ansible variable to define the URL in a single place, which will simplify future updates. I also found an outdated code comment that should be updated.

gemini-code-assist · 2025-10-03T09:41:43Z

roles/os_container_clusters/defaults/main.yml

 os_container_clusters_templates: []
 # Upper constraints file for installation of python dependencies.
-os_container_clusters_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_container_clusters_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_container_clusters_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

gemini-code-assist · 2025-10-03T09:41:43Z

roles/os_deploy_templates/defaults/main.yml


 # Upper constraints file for installation of Python dependencies.
-os_deploy_templates_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_deploy_templates_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_deploy_templates_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

gemini-code-assist · 2025-10-03T09:41:44Z

roles/os_images/defaults/main.yml


 # Use Caracal upper constraints
-os_images_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_images_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


The comment on the preceding line (15), # Use Caracal upper constraints, is now outdated. The 2024.1 release corresponded to Caracal, but this has been updated to 2025.1. To prevent confusion, please update this comment. Using a more generic description like Upper constraints file for installation of Python dependencies. would be more robust for future updates.

gemini-code-assist · 2025-10-03T09:41:44Z

roles/os_images/defaults/main.yml


 # Use Caracal upper constraints
-os_images_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_images_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_images_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

gemini-code-assist · 2025-10-03T09:41:44Z

roles/os_networks/defaults/main.yml


 # Upper constraints file for installation of Python dependencies.
-os_networks_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_networks_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_networks_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

gemini-code-assist · 2025-10-03T09:41:44Z

roles/os_openstacksdk/defaults/main.yml

 os_openstacksdk_version:
 # Upper constraints file for installation of openstacksdk.
-os_openstacksdk_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_openstacksdk_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_openstacksdk_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

gemini-code-assist · 2025-10-03T09:41:44Z

roles/os_projects/README.md

        - role: stackhpc.openstack.os_projects
          os_projects_venv: "~/os-projects-venv"
-          os_projects_upper_constraints_file: "https://releases.openstack.org/constraints/upper/2024.1"
+          os_projects_upper_constraints_file: "https://releases.openstack.org/constraints/upper/2025.1"


This example hardcodes the upper constraints URL. To align with best practices for maintainability (as suggested for the role defaults), consider updating this example to use a variable for the URL. This demonstrates a more robust configuration pattern to users.

For example:

- name: Ensure OpenStack projects are registered hosts: localhost vars: upper_constraints_url: "https://releases.openstack.org/constraints/upper/2025.1" roles: - role: stackhpc.openstack.os_projects os_projects_venv: "~/os-projects-venv" os_projects_upper_constraints_file: "{{ upper_constraints_url }}" # ... rest of the config

gemini-code-assist · 2025-10-03T09:41:44Z

roles/os_projects/defaults/main.yml

 # 'quotas': Optional dict mapping quota names to their values.
 os_projects: [] # noqa var-naming[no-role-prefix]
-os_projects_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_projects_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_projects_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

gemini-code-assist · 2025-10-03T09:41:44Z

roles/os_ratings/defaults/main.yml

 os_ratings_venv:
 # Upper constraints file for installation of Python dependencies.
-os_ratings_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_ratings_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_ratings_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

gemini-code-assist · 2025-10-03T09:41:45Z

roles/os_volumes/defaults/main.yml


 # A file or URL containing Python upper constraints.
-os_volumes_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
+os_volumes_upper_constraints_file: https://releases.openstack.org/constraints/upper/2025.1


To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this hardcoded URL can be made overridable by a common variable. This centralizes the configuration and simplifies future updates.

os_volumes_upper_constraints_file: "{{ os_upper_constraints_file | default('https://releases.openstack.org/constraints/upper/2025.1') }}"

Replace 2024.1 upper constraint with 2025.1

a72eb3d

MaxBed4d requested a review from a team as a code owner October 3, 2025 09:38

gemini-code-assist bot reviewed Oct 3, 2025

View reviewed changes

Replace 2024.1 upper constraint with 2025.1 #71

Are you sure you want to change the base?

Replace 2024.1 upper constraint with 2025.1 #71

Uh oh!

Conversation

MaxBed4d commented Oct 3, 2025

Uh oh!

gemini-code-assist bot commented Oct 3, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants