Add alerting for RadosGW Usage Exporter metrics #1911
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new Prometheus alert, RadosGWUsageExporterNotServingMetrics, to monitor the RadosGW Usage Exporter, and includes a corresponding release note. My review identified a critical issue with the Prometheus rule definition that will result in an invalid file, preventing Prometheus from loading it. I have also noted a minor typo in the release note. Please see the detailed comments for suggestions on how to resolve these issues.
releasenotes/notes/alert-on-radosgw-usage-exporter-8f03f7013204ea22.yaml
Outdated
Show resolved
Hide resolved
MoteHue
force-pushed
the
alert-on-radosgw-usage-exporter
branch
2 times, most recently
from
7cffca7 to
c14dfc2
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new Prometheus alert, RadosGWUsageExporterNotServingMetrics, to monitor the RadosGW Usage Exporter, along with a corresponding release note. The new alert is a valuable addition for ensuring the reliability of RGW usage metrics collection. However, I've identified a critical issue with how the new alert rule is added to the configuration file, which will result in an invalid YAML file and cause Prometheus rule loading to fail. My review includes a detailed explanation of the issue and guidance on how to resolve it.
|
recheck |
MoteHue
force-pushed
the
alert-on-radosgw-usage-exporter
branch
from
e125e69 to
82323bb
Compare
|
recheck |
No description provided.