Add playbook and kayobe automation breaking change info #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for two breaking changes in Epoxy. My review focuses on the correctness and clarity of the added documentation. I've found a couple of issues: a grammatical error that affects clarity, and a docker build command example that is syntactically incorrect and would fail if executed. I've provided suggestions to fix both of these issues.
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
force-pushed
the
add-missing-breaking-changes
branch
from
bbed8b8 to
7b9c086
Compare
Alex-Welsh
reviewed
Nov 11, 2025
seunghun1ee
force-pushed
the
add-missing-breaking-changes
branch
from
7b9c086 to
9497991
Compare
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
force-pushed
the
add-missing-breaking-changes
branch
from
9497991 to
3b8558f
Compare
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
requested changes
Nov 13, 2025
| option to specify Beokay to use Python 3.12 as it is not the default. | ||
|
|
||
| For CI, Kayobe Automation image also needs to be rebuilt with Python 3.12. | ||
| Running the workflow from ``.github/workflows/stackhpc-build-kayobe-image.yml`` |
Member
There was a problem hiding this comment.
This isn't quite right.
This one you have referenced is just the one we use for SKC.
The generic one that clients use is called build-kayobe-docker-image.yml, it's written out by ansible-collection-kayobe-automation
seunghun1ee
force-pushed
the
add-missing-breaking-changes
branch
from
3b8558f to
257fdac
Compare
Added more detail about two breaking changes on Epoxy. 1. Any playbook reference other than symlinks can break with new subdirectories of playbooks. 2. Kayobe Automation image needs to be rebuilt with Python 3.12.
seunghun1ee
force-pushed
the
add-missing-breaking-changes
branch
from
257fdac to
4e17510
Compare
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
reviewed
Nov 24, 2025
Co-authored-by: Alex Welsh <112560678+Alex-Welsh@users.noreply.github.com>
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
approved these changes
Nov 24, 2025
Member
|
LGTM, CI is just a bit broken at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more detail about two breaking changes on Epoxy.