Add removing a hypervisor doc section #1984
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a helpful documentation section on the process of removing a hypervisor. The steps provided are logical and cover the necessary actions. My review includes a few suggestions to improve the command-line examples for clarity, robustness, and ease of use, such as replacing grep with specific flags and removing shell prompts from code blocks to prevent copy-paste errors.
doc/source/operations/bifrost-hardware-inventory-management.rst
Outdated
Show resolved
Hide resolved
Alex-Welsh
force-pushed
the
rm-hypervisor-doc
branch
from
87e3344 to
968646c
Compare
Alex-Welsh
force-pushed
the
rm-hypervisor-doc
branch
from
968646c to
82ad19a
Compare
Alex-Welsh
force-pushed
the
rm-hypervisor-doc
branch
from
82ad19a to
3bb9d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.