Skip to content

fix(postgresflex): remove storage class flag from instance update cmd #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −12
Open

fix(postgresflex): remove storage class flag from instance update cmd #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ require (
github.com/stackitcloud/stackit-sdk-go/services/iaas v0.31.0
github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v1.5.2
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.1
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.2.1
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.3.0
github.com/stackitcloud/stackit-sdk-go/services/resourcemanager v0.17.1
github.com/stackitcloud/stackit-sdk-go/services/runcommand v1.3.1
github.com/stackitcloud/stackit-sdk-go/services/secretsmanager v0.13.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,8 +587,8 @@ github.com/stackitcloud/stackit-sdk-go/services/observability v0.15.0 h1:MA5i1Sc
github.com/stackitcloud/stackit-sdk-go/services/observability v0.15.0/go.mod h1:tJEOi6L0le4yQZPGwalup/PZ13gqs1aCQDqlUs2cYW0=
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.1 h1:50n87uZn0EvSP9hJGLqd3Wm2hfqbyh7BMGGCk7axgqA=
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.1/go.mod h1:jfguuSPa56Z5Bzs/Xg/CI37XzPo5Zn5lzC5LhfuT8Qc=
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.2.1 h1:K8vXele3U6b5urcSIpq21EkVblWfPDY3eMPSuQ48TkI=
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.2.1/go.mod h1:hyhw+I19NtjKmRLcUkY4boaTxnYSPFGbpn4RxvGqH2s=
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.3.0 h1:bRTjGuRURl7Gs2eumIqW0hXTzoOBA1nWZkfcligMsZY=
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.3.0/go.mod h1:I/2cg1SU61M+8X1UDVB154D13I2Uk0wObKvo6Je6NFs=
github.com/stackitcloud/stackit-sdk-go/services/rabbitmq v0.25.1 h1:ALrDCBih8Fu8e6530KdOjuH0iMxOLntO381BbKFlTFY=
github.com/stackitcloud/stackit-sdk-go/services/rabbitmq v0.25.1/go.mod h1:+qGWSehoV0Js3FalgvT/bOgPj+UqW4I7lP5s8uAxP+o=
github.com/stackitcloud/stackit-sdk-go/services/redis v0.25.1 h1:8uPt82Ez34OYMOijjEYxB1zUW6kiybkt6veQKl0AL68=
Expand Down
13 changes: 4 additions & 9 deletions internal/cmd/postgresflex/instance/update/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const (
flavorIdFlag = "flavor-id"
cpuFlag = "cpu"
ramFlag = "ram"
storageClassFlag = "storage-class"
storageSizeFlag = "storage-size"
versionFlag = "version"
typeFlag = "type"
Expand Down Expand Up @@ -135,7 +134,6 @@ func configureFlags(cmd *cobra.Command) {
cmd.Flags().String(flavorIdFlag, "", "ID of the flavor")
cmd.Flags().Int64(cpuFlag, 0, "Number of CPUs")
cmd.Flags().Int64(ramFlag, 0, "Amount of RAM (in GB)")
cmd.Flags().String(storageClassFlag, "", "Storage class")
cmd.Flags().Int64(storageSizeFlag, 0, "Storage size (in GB)")
cmd.Flags().String(versionFlag, "", "Version")
cmd.Flags().Var(flags.EnumFlag(false, "", typeFlagOptions...), typeFlag, fmt.Sprintf("Instance type, one of %q", typeFlagOptions))
Expand All @@ -155,13 +153,12 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
ram := flags.FlagToInt64Pointer(p, cmd, ramFlag)
acl := flags.FlagToStringSlicePointer(p, cmd, aclFlag)
backupSchedule := flags.FlagToStringPointer(p, cmd, backupScheduleFlag)
storageClass := flags.FlagToStringPointer(p, cmd, storageClassFlag)
storageSize := flags.FlagToInt64Pointer(p, cmd, storageSizeFlag)
version := flags.FlagToStringPointer(p, cmd, versionFlag)
instanceType := flags.FlagToStringPointer(p, cmd, typeFlag)

if instanceName == nil && flavorId == nil && cpu == nil && ram == nil && acl == nil &&
backupSchedule == nil && storageClass == nil && storageSize == nil && version == nil && instanceType == nil {
backupSchedule == nil && storageSize == nil && version == nil && instanceType == nil {
return nil, &cliErr.EmptyUpdateError{}
}

Expand All @@ -181,7 +178,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
FlavorId: flavorId,
CPU: cpu,
RAM: ram,
StorageClass: storageClass,
StorageSize: storageSize,
Version: version,
Type: instanceType,
Expand Down Expand Up @@ -265,11 +261,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient PostgreSQLFl
payloadAcl = &postgresflex.ACL{Items: model.ACL}
}

var payloadStorage *postgresflex.Storage
var payloadStorage *postgresflex.StorageUpdate
if model.StorageClass != nil || model.StorageSize != nil {
payloadStorage = &postgresflex.Storage{
Class: model.StorageClass,
Size: model.StorageSize,
payloadStorage = &postgresflex.StorageUpdate{
Size: model.StorageSize,
}
}

Expand Down
Loading