remove InterpreterResult as Result alias throughout and rename to VmExecutionResult

[jferrant]

I am okay with removing InterpreterResult alias throughout the code base entirely but it will be quite a large change. Let me know your thoughts. (will also add some conflicts so might wait until the Error renames are done before doing the full replacement) If we do decide to keep InterpreterResult as VmExecutionResult, I will go throughout the codebase after to update all instances of Result<T, VmExecutionError> to use it as well but want feedback first.

[fdefelici]

I am okay with removing InterpreterResult alias throughout the code base entirely but it will be quite a large change. Let me know your thoughts. (will also add some conflicts so might wait until the Error renames are done before doing the full replacement) If we do decide to keep InterpreterResult as VmExecutionResult, I will go throughout the codebase after to update all instances of Result<T, VmExecutionError> to use it as well but want feedback first.

I agree! I mean we are not in hurry and we could the less painfull way to remove this alias.
So, I'm fine with doing this activity after the other updates.

[jcnelson]

LGTM; happy to re-approve once merge conflicts are resolved

[codecov]

Codecov Report

❌ Patch coverage is 95.74315% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.77%. Comparing base (49727a3) to head (576c35e).
⚠️ Report is 644 commits behind head on develop.

Files with missing lines	Patch %	Lines
stackslib/src/clarity_vm/database/marf.rs	70.83%	14 Missing ⚠️
clarity/src/vm/database/clarity_store.rs	15.38%	11 Missing ⚠️
stackslib/src/clarity_vm/database/ephemeral.rs	57.89%	8 Missing ⚠️
clarity/src/vm/database/sqlite.rs	78.57%	6 Missing ⚠️
clarity/src/vm/database/clarity_db.rs	96.06%	5 Missing ⚠️
stackslib/src/clarity_vm/database/mod.rs	50.00%	5 Missing ⚠️
clarity/src/vm/mod.rs	81.81%	4 Missing ⚠️
clarity/src/vm/functions/arithmetic.rs	94.11%	3 Missing ⚠️
clarity/src/vm/database/key_value_wrapper.rs	81.81%	2 Missing ⚠️
clarity/src/vm/contexts.rs	99.18%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6507      +/-   ##
===========================================
- Coverage    80.03%   79.77%   -0.27%     
===========================================
  Files          565      565              
  Lines       346446   346528      +82     
===========================================
- Hits        277282   276440     -842     
- Misses       69164    70088     +924     

Files with missing lines	Coverage Δ
clarity-types/src/errors/mod.rs	75.30% <ø> (ø)
clarity-types/src/types/mod.rs	95.88% <100.00%> (+0.03%)	⬆️
clarity/src/vm/callables.rs	96.30% <100.00%> (ø)
clarity/src/vm/contracts.rs	100.00% <100.00%> (ø)
clarity/src/vm/costs/cost_functions.rs	100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_1.rs	100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_2.rs	100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_2_testnet.rs	100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_3.rs	100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_4.rs	100.00% <100.00%> (ø)
... and 26 more

... and 57 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49727a3...576c35e. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.