-
Notifications
You must be signed in to change notification settings - Fork 715
fix: emit receipt for costs-4 deploy
#6679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emit receipt for costs-4 deploy
#6679
Conversation
|
Removed from the queue to add changeling entry. Will re-request reviews shortly. 🙏 |
aa1ba68
|
@adriano-stacks I added a note to the changelog. We can include something similar to the release notes. Let me know if you'd like to add or modify this. |
|
Thanks @brice-stacks. I have a couple questions:
|
I would recommend selecting an archive file from before the fork, then boot from that. I can add a suggestion in the changelog, but I don't want to be overly prescriptive.
I'd say this is up to the API team to figure out if there is a good way to do it or not. Maybe we should wait to hear from them to see if there is something they'd want us to put in this changelog, or maybe a link to their documentation on it. |
Got it thanks. What do you think of this?
If you are ok with the suggestion (or something along those lines) I think we fine. |
Co-authored-by: Adriano <228035176+adriano-stacks@users.noreply.github.com>
|
I like it, thanks! |
|
Thank you! I'll let the others approve the code changes, I am good with the changelog. |
dd1b787
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (71.68%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6679 +/- ##
===========================================
- Coverage 79.58% 71.68% -7.90%
===========================================
Files 575 577 +2
Lines 355807 356944 +1137
===========================================
- Hits 283157 255891 -27266
- Misses 72650 101053 +28403
... and 286 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This receipt should have been emitted when initializing epoch 3.3. This change is not consensus breaking, but it does change the events that the API will see.