Update ConsensusTest to enable invalid pre-naka blocks #6684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
jacinta-stacks
requested review from
aaronb-stacks,
brice-stacks,
federico-stacks and
francesco-stacks
… into fix/make-pre-naka-blocks-failable
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into fix/make-pre-naka-blocks-failable
brice-stacks
previously approved these changes
Nov 14, 2025
Contributor
brice-stacks
left a comment
brice-stacks
left a comment
There was a problem hiding this comment.
This looks good, just had one suggestion on a comment.
Contributor
aaronb-stacks
left a comment
aaronb-stacks
left a comment
There was a problem hiding this comment.
LGTM! just need to update the comment Brice pointed out
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
brice-stacks
previously approved these changes
Nov 15, 2025
francesco-stacks
previously approved these changes
Nov 17, 2025
francesco-stacks
left a comment
francesco-stacks
left a comment
There was a problem hiding this comment.
just a couple of nits. feel free to ignore and resolve the conversations
aaronb-stacks
previously approved these changes
Nov 17, 2025
… into fix/make-pre-naka-blocks-failable
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
jacinta-stacks
dismissed stale reviews from aaronb-stacks, francesco-stacks, and brice-stacks
via
acef361
… into fix/make-pre-naka-blocks-failable
jacinta-stacks
dismissed stale reviews from brice-stacks and francesco-stacks
via
0e12150
jacinta-stacks
requested review from
aaronb-stacks,
brice-stacks and
francesco-stacks
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
jacinta-stacks
force-pushed
the
fix/make-pre-naka-blocks-failable
branch
from
0e12150 to
594a7be
Compare
brice-stacks
approved these changes
Nov 17, 2025
aaronb-stacks
approved these changes
Nov 17, 2025
Merged
via the queue into
stacks-network:develop
with commit Nov 17, 2025
697fe43
306 of 312 checks passed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the evaluated epoch of the block that failed since it seemed important even in the fail case. Open to suggestions on that though.
I really felt like I was slapping a whole lot of guesswork together...but it does seem to work as expected... There may very well be potential for simplification and cleanup but earlier eyes would be good.
@brice-stacks take a look at the output sepcifically of the problematic supertype test .
Replaces #6674
Closes #6567