Skip to content

Conversation

@francesco-stacks
Copy link

@francesco-stacks francesco-stacks commented Nov 25, 2025

Description

Fifth of 7 PRs that will supersede #6661

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this Nov 25, 2025
@francesco-stacks francesco-stacks added aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task labels Nov 25, 2025
@francesco-stacks francesco-stacks marked this pull request as ready for review November 25, 2025 13:32
@francesco-stacks francesco-stacks moved this to Status: In Review in Stacks Core Eng Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.18%. Comparing base (76936b5) to head (3002fc4).
⚠️ Report is 3 commits behind head on develop.

❌ Your project status has failed because the head coverage (75.18%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6715      +/-   ##
===========================================
+ Coverage    75.01%   75.18%   +0.16%     
===========================================
  Files          577      577              
  Lines       357690   357795     +105     
===========================================
+ Hits        268313   268994     +681     
+ Misses       89377    88801     -576     
Files with missing lines Coverage Δ
...slib/src/chainstate/tests/static_analysis_tests.rs 84.10% <100.00%> (-1.36%) ⬇️

... and 314 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76936b5...3002fc4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Nov 25, 2025
@jacinta-stacks jacinta-stacks added this pull request to the merge queue Nov 25, 2025
Merged via the queue into stacks-network:develop with commit 44fdf84 Nov 25, 2025
302 of 312 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants