feat: integrate nest-asyncio for async tool calls #9056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chenmoneygithub
left a comment
chenmoneygithub
left a comment
There was a problem hiding this comment.
I need to do some testing on this, as I remember the nest-asyncio was causing unexpected errors on async calling.
Btw, the uv.lock update seems wrong to me, it shouldn't change every line.
…loops - Added nest-asyncio as a dependency to allow calling async tools from within a running event loop. - Updated the Tool class to apply nest-asyncio when the event loop is already running. - Enhanced syncify utility to raise an ImportError if nest-asyncio is not installed when needed. - Added a new test case to verify async tool calls from a running event loop. This change improves compatibility with environments like Jupyter notebooks where event loops are already active. Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
TomeHirata
force-pushed
the
fix/nest-asyncio
branch
from
792929e to
1d83504
Compare
Collaborator
Author
|
@chenmoneygithub Yes please! Also updated uv.lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nest-asyncio.pyproject.tomlto includenest-asyncioas a test dependency.nest-asyncioif not found.