feat(@desktop/biometric): wait for biometrics confirmation to complete before landing on homepage #19134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Jenkins BuildsClick to see older builds (1)
|
alaibe
approved these changes
Oct 24, 2025
|
@Khushboo-dev-cpp, checked build 1 on Android - looks good to me - happy if you merge it |
…e before landing on homepage fixes #19013
Khushboo-dev-cpp
force-pushed
the
fix/19013
branch
from
fc0ad57 to
a62b951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19013
What does the PR do
Stay on
Preparing Statusuntil biometric flow is completeAffected areas
Biometric flow on onboarding
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Android Happy Path
https://github.com/user-attachments/assets/f17c19e9-7f0a-4344-98dc-e4b145a5900e
Android Failed Biometrics Path
https://github.com/user-attachments/assets/1d8c6a86-1cad-4174-b918-d9a79314d3ca
iOS
https://github.com/user-attachments/assets/6861006c-c02c-4c3f-b63c-1ae09bbfa985
Impact on end user
How to test
Risk