Skip to content

fix: use deterministic comparison ordering #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use deterministic comparison ordering #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions jsonpatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,18 +859,17 @@ def _item_replaced(self, path, key, item):
}, pointer_cls=self.pointer_cls))

def _compare_dicts(self, path, src, dst):
src_keys = set(src.keys())
dst_keys = set(dst.keys())
added_keys = dst_keys - src_keys
removed_keys = src_keys - dst_keys
added_keys = [key for key in dst.keys() if key not in src.keys()]
removed_keys = [key for key in src.keys() if key not in dst.keys()]
intersection = [key for key in src.keys() if key in dst.keys()]
Comment on lines +862 to +864
Copy link
Preview

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list comprehension with if key not in src.keys() will result in O(n²) time complexity for large dictionaries since in operation on dict.keys() is O(n). Consider using added_keys = [key for key in dst if key not in src] instead, which maintains O(n) complexity.

Suggested change
added_keys = [key for key in dst.keys() if key not in src.keys()]
removed_keys = [key for key in src.keys() if key not in dst.keys()]
intersection = [key for key in src.keys() if key in dst.keys()]
added_keys = [key for key in dst if key not in src]
removed_keys = [key for key in src if key not in dst]
intersection = [key for key in src if key in dst]

Copilot uses AI. Check for mistakes.

Comment on lines +863 to +864
Copy link
Preview

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the line above, this will have O(n²) complexity. Use removed_keys = [key for key in src if key not in dst] to maintain O(n) performance.

Suggested change
removed_keys = [key for key in src.keys() if key not in dst.keys()]
intersection = [key for key in src.keys() if key in dst.keys()]
dst_keys = set(dst.keys())
removed_keys = [key for key in src.keys() if key not in dst_keys]
intersection = [key for key in src.keys() if key in dst_keys]

Copilot uses AI. Check for mistakes.

Copy link
Preview

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also has O(n²) complexity. Use intersection = [key for key in src if key in dst] for better performance.

Suggested change
intersection = [key for key in src.keys() if key in dst.keys()]
intersection = list(set(src.keys()) & set(dst.keys()))

Copilot uses AI. Check for mistakes.


for key in removed_keys:
self._item_removed(path, str(key), src[key])

for key in added_keys:
self._item_added(path, str(key), dst[key])

for key in src_keys & dst_keys:
for key in intersection:
self._compare_values(path, key, src[key], dst[key])

def _compare_lists(self, path, src, dst):
Expand Down