Upgraded to .NET 10 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…checkout-5 Bump actions/checkout from 4 to 5
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…stale-10 Bump actions/stale from 9 to 10
…setup-dotnet-5 Bump actions/setup-dotnet from 4 to 5
Migrated all project files, build scripts, and CI workflow from .NET 8 to .NET 10 for Android, iOS, MacCatalyst, and Windows targets. Updated related paths and conditions in build and publish scripts. Fixed a typo in the README and removed the project history section.
Removed iOS and MacCatalyst from the TargetFrameworks list, restricting the project to build only for Android. Also removed a Windows-specific PropertyGroup related to Android SDK directory configuration.
Bump .NET version to 10.0.x in the GitHub Actions workflow and update the project to target net10.0-windows. Replace explicit MAUI workload installs with 'dotnet workload restore' and update Microsoft.Windows.Compatibility package to version 10.0.0.
The GitHub Actions workflow for dotnet will no longer run on pull request events. This change may be intended to limit workflow runs to pushes and manual dispatches only.
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade the project from .NET 8 to .NET 10, updating target frameworks across multiple project files, build scripts, and CI/CD workflows. The PR also includes a spelling correction in the README and removes some historical documentation sections.
- Updated target frameworks from net8.0 to net10.0 across all project files
- Updated GitHub Actions workflow to use newer action versions and .NET 10
- Corrected spelling of "Commont" to "Common" in README.md
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| publishAndroidApp.ps1 | Updated Android publish script to target net10.0-android framework |
| README.md | Fixed spelling error and updated Obtainium badge URL, removed history section |
| LockPDFyWinforms/LockPDFyWinforms.csproj | Updated to net10.0-windows and Microsoft.Windows.Compatibility 10.0.0 |
| LockPDFyTests/LockPDFyTests.csproj | Updated to net10.0 target framework |
| LockPDFyMaui/LockPDFyMaui.csproj | Updated to net10.0 frameworks, removed iOS/macOS targets and Android SDK workaround |
| .github/workflows/stale.yml | Updated actions/stale to v10 |
| .github/workflows/dotnet.yml | Updated to use .NET 10.0.x, newer action versions, and workload restore approach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.