Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -932,18 +932,11 @@ public boolean hasPermission(final Team team, String permissionName) {
* @since 1.1.1
*/
public boolean hasPermission(final ApiKey apiKey, String permissionName) {
if (apiKey.getTeams() == null) {
return false;
}
for (final Team team: apiKey.getTeams()) {
final List<Permission> teamPermissions = getObjectById(Team.class, team.getId()).getPermissions();
for (final Permission permission: teamPermissions) {
if (permission.getName().equals(permissionName)) {
return true;
}
}
}
return false;
final Query<Permission> query = pm.newQuery(Permission.class, "name == :permissionName && apiKey.contains(apiKey) && apiKey.id == :apiKeyId");
query.declareVariables("alpine.model.ApiKey apiKey");
query.setParameters(permissionName, apiKey.getId());
query.setResult("count(id)");
return executeAndCloseResultUnique(query, Long.class) > 0;
}

/**
Expand Down
14 changes: 14 additions & 0 deletions alpine-model/src/main/java/alpine/model/ApiKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ public class ApiKey implements Serializable, Principal {
@JsonIgnore
private List<Team> teams;

@Persistent(table = "APIKEYS_PERMISSIONS", defaultFetchGroup = "true")
@Join(column = "APIKEY_ID")
@Element(column = "PERMISSION_ID")
@Order(extensions = @Extension(vendorName = "datanucleus", key = "list-ordering", value = "name ASC"))
private List<Permission> permissions;

@Persistent
@Unique(name = "APIKEY_PUBLIC_IDX")
@Size(min = LEGACY_PUBLIC_ID_LENGTH, max = PUBLIC_ID_LENGTH)
Expand Down Expand Up @@ -197,6 +203,14 @@ public void setTeams(List<Team> teams) {
this.teams = teams;
}

public List<Permission> getPermissions() {
return permissions;
}

public void setPermissions(List<Permission> permissions) {
this.permissions = permissions;
}

public String getPublicId() {
return publicId;
}
Expand Down
13 changes: 12 additions & 1 deletion alpine-model/src/main/java/alpine/model/Permission.java
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ public class Permission implements Serializable {
@JsonIgnore
private List<ManagedUser> managedUsers;

@Persistent(mappedBy = "permissions")
@JsonIgnore
private List<ApiKey> apiKeys;

public long getId() {
return id;
}
Expand Down Expand Up @@ -140,5 +144,12 @@ public List<ManagedUser> getManagedUsers() {
public void setManagedUsers(List<ManagedUser> managedUsers) {
this.managedUsers = managedUsers;
}
}

public List<ApiKey> getApiKeys() {
return apiKeys;
}

public void setApiKeys(List<ApiKey> apiKeys) {
this.apiKeys = apiKeys;
}
}
23 changes: 23 additions & 0 deletions alpine-model/src/test/java/alpine/model/ApiKeyTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@
*/
package alpine.model;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;

import java.util.ArrayList;
import java.util.List;

public class ApiKeyTest {

@Test
Expand All @@ -31,4 +35,23 @@ public void maskTest() {
assertThat(apiKey.getMaskedKey()).isEqualTo("alpine_TL1xa********************************");
}

@Test
public void teamsTest() {
List<Team> teams = new ArrayList<>();
teams.add(new Team());
ApiKey key = new ApiKey();
key.setTeams(teams);
Assertions.assertEquals(teams, key.getTeams());
Assertions.assertEquals(1, key.getTeams().size());
}

@Test
public void permissionsTest() {
List<Permission> permissions = new ArrayList<>();
permissions.add(new Permission());
ApiKey user = new ApiKey();
user.setPermissions(permissions);
Assertions.assertEquals(permissions, user.getPermissions());
Assertions.assertEquals(1, user.getPermissions().size());
}
}