Feat: For the AWS EMF and XRay exporters, changing their respective '… #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @JeremieRodon , I'll take a look at this tomorrow. |
mheffner
approved these changes
Dec 29, 2025
Contributor
mheffner
left a comment
mheffner
left a comment
There was a problem hiding this comment.
Looks great, thanks for the PR!
Contributor
|
I have a PR that should fix the workflows to run here: #256 |
Contributor
|
Can you merge from main to include this PR: #256? That should allow us to schedule the status checks |
…region' argument so that, if unset, it tries to use AWS_REGION and AWS_DEFAULT_REGION (in that order) before defaulting to us-east-1. Rationnal: from an AWS user perpective, it is expected that the default behavior is to use whatever default region the user has set, if any. All changes: - Implemented Default on the exporters::shared::aws::Region struct - Implemented core::str::FromStr on the Region struct so we can parse strings in a more controlled maner - Defered the previous From<String> impl to str::parse() - Removed the clap::value_enum flag on the XRay/EMF arguments because the clap::ValueEnum trait is not implemented on Region anyway - Updated the documentation of both configuration arg to reflect the change
…h I'm not sure it is really used in practice I suppose it is more coherent to include it in the change)
JeremieRodon
force-pushed
the
feat/default-current-aws-region
branch
from
2ce7a7b to
624614c
Compare
Contributor
Author
|
@mheffner Done on all 3 PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the AWS EMF and XRay exporters, changing their respective 'region' argument so that, if unset, it tries to use
AWS_REGIONandAWS_DEFAULT_REGIONenvironment variables (in that order) before defaulting tous-east-1.Rational: from an AWS user perspective, it is expected that the default behavior is to use whatever default region the user has set, if any.
All changes:
Defaulttrait onexporters::shared::aws::Regioncore::str::FromStrtrait onexporters::shared::aws::Regionso we can parse strings in a more controlled mannerFrom<String>trait implementation tostr::parse()clap::value_enumflag on the XRay/EMF arguments because theclap::ValueEnumtrait is not implemented onexporters::shared::aws::Regionanyway