add optional "caseInsensitivity" for volume - to reproduce windows behaviour #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a use case where we would like to see an option to support case insensitivity as well. I would be happy to resolve any conflicts in this branch to see this PR to completion if it is a feature that would be accepted. |
|
@jmfirth-arkane go for it - aside from the unneeded formatting changes, I think the only change needed is lets use an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a PR introduced for version 3.2 - It required rebasing;
My PR just update this and resubmits it.
Original PR: #632 : Feb 9, 2021
ajafff@b214f0e#diff-22b97ef1141174ca5a814b313942e79b626a55c7cd1ebe7b97d0756298b03641
NOTE:
"test": "jest --maxWorkers 2",
This is removed as it breaks debugging from vscode;