feat(bluelight): add auto option to change based on location #483
Conversation
|
Is there a difference to #476 ? |
|
I may have forgotten that i pushed #476 :D The difference is that this PR have an |
|
But this PR builds on top of the other, so this should really point to the other branch. If you merge the other one first it should become apparant what this one does :) |
|
Do you mind editing the title to include a WIP: so it won't get merged in the „wrong” order? |
Dynge
changed the title
done :) |
Dynge
changed the title
|
Hm, is a rebase needed? I cannot see a difference to before the merge of #476 here. |
Dynge
force-pushed
the
mdl/push-owtzuonvppno
branch
2 times, most recently
from
efbee12 to
1fdb5c4
Compare
Yep. Should be rebased properly now :) |
Dynge
force-pushed
the
mdl/push-owtzuonvppno
branch
from
1fdb5c4 to
4324629
Compare
|
Luacheck is failing. Good ol' ArchLinux wiki. |
| end | ||
| if opts.auto then | ||
| gears.timer({ | ||
| timeout = 60, |
There was a problem hiding this comment.
That's in seconds? Or minutes?
Do we really need to check every minute here? 🤔
There was a problem hiding this comment.
its seconds, and no - We do not. We could check every 5 minute? I dont really have a good feel for what would be preferable, however I think it does not really matter. Executing the process every minute or 5 minutes is not gonna matter performance wise (i think)
Dynge
force-pushed
the
mdl/push-owtzuonvppno
branch
from
4324629 to
1a8c655
Compare
Should be fixed now :) |
Dynge
force-pushed
the
mdl/push-owtzuonvppno
branch
from
1a8c655 to
24a4b38
Compare
|
Ah, #479 wasn't merged. Nevermind. |
2 participants
Updated the bluelight widget to use a factory method such that it is easier to supply arguments to the widget.
Furthermore Ive added an option
opts.autoto select if the bluelight filter should automatically start or not.