-
-
Notifications
You must be signed in to change notification settings - Fork 1k
No:2743 - 𝐒 Improve GameStudio's About window - Added a new markdown plugin window to show "MIT License" and "See all list" links in the About page #2921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: xplat-editor
Are you sure you want to change the base?
Conversation
… show the markdown files
Nice. Can we have some screenshots? |
@jithishkumarg please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
<ItemGroup> | ||
<Compile Update="Views\MarkdownViewerWindow.axaml.cs"> | ||
<DependentUpon>MarkdownViewerWindow.axaml</DependentUpon> | ||
</Compile> | ||
</ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.axaml
files and their .cs
counterpart are detected automatically. There is no need to add them to the project file.
<PackageVersion Include="DotRecast.Recast.Toolset" Version="2024.3.1" /> | ||
<PackageVersion Include="FFmpeg.AutoGen" Version="3.4.0.2" /> | ||
<PackageVersion Include="K4os.Compression.LZ4.Legacy" Version="1.3.6" /> | ||
<PackageVersion Include="Markdown.Avalonia" Version="11.0.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Packages are grouped depending on their runtime or design dependency. Here it is only used by the GaleStudio so it should be next to the other Avalonia dependencies.
using Avalonia.Controls; | ||
using Stride.GameStudio.Avalonia.Views; | ||
|
||
namespace Stride.GameStudio.Avalonia.Services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use file scope namespace
@@ -0,0 +1,48 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this shouldn't be necessary thanks to implicit usings.
{ | ||
public static class MarkdownFileViewerService | ||
{ | ||
public static void ShowFile(string filePath, string title = "Markdown Viewer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this helper method should be made async. Have a look at the other dialog implementations in the DialogService.
private void InitializeComponent() | ||
{ | ||
AvaloniaXamlLoader.Load(this); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be generated automatically by the analyzers provided by Avalonia libraries.
… show the markdown files
PR Details
#2743
Related Issue
Types of changes
Checklist