Skip to content

Conversation

amyspark
Copy link
Contributor

@amyspark amyspark commented Jan 6, 2023

By using CMake's official Find Modules and sidestepping pkg-config altogether, we're able to use imported targets without further complexity.

By using CMake's official Find Modules and sidestepping pkg-config
altogether, we're able to use imported targets without further complexity.
@farindk
Copy link
Contributor

farindk commented Jan 18, 2023

Thank you. By accident, I did much of the same work as in your patch just yesterday.
Could have saved me a lot of time had I seen this earlier :-)

I added the unset() lines from your patch (see above).
We cannot yet use the JPEG::JPEG syntax, because we still depend on an older cmake version for packaging on ancient Linux versions. Thus, I'll leave your pull request open as a reminder to use this syntax at a later time.

@amyspark
Copy link
Contributor Author

Great to hear @farindk, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants