Skip to content

Fix unnecessary pings and add retry queries #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix unnecessary pings and add retry queries #196

wants to merge 3 commits into from

Conversation

kkmuffme
Copy link
Contributor

@kkmuffme kkmuffme commented Jan 8, 2025

  • queries slower than heartbeat recheck_timeout would trigger unnecessary heartbeat pings
  • unnecessary heartbeat pings after we just pinged if less servers than retries
  • fix if ping (e.g. due to network congestion or physical distance) would exceed recheck_timeout
  • fix broken connection not removed if heartbeats disabled
  • automatically retry query if server went away (like WP core wpdb does https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/class-wpdb.php#L2274)

@kkmuffme
Fix unnecessary pings
867b1ff 
* queries slower than heartbeat recheck_timeout would trigger unnecessary heartbeat pings
* unnecessary heartbeat pings after we just pinged if less servers than retries
* fix if ping (e.g. due to network congestion or physical distance) would exceed recheck_timeout
@kkmuffme
retry/ping if server went away but heartbeats are disabled to ensure …
a13d6a0 
…the server will not be reused and disconnected
@kkmuffme
retry the query
1159754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kkmuffme