feat: drop JSON functions and dependency on substrait-cpp #100
Conversation
Also drop json test which depends on contents of substrait-cpp library
There is no official substrait JSON API, though users are more than welcome to use the official JSON representation of protobufs in general. Considering that these functions were just thin wrappers around the protobuf JSON api and that the tests are really just testing another libraries code, it made sense to remove them. BREAKING CHANGE: drop functions handling JSON versions of plans.
| / "substrait" | ||
| / "textplan" | ||
| / "data" | ||
| ) |
There was a problem hiding this comment.
So as I understand it, this test is functionally just proving that the underlying protobuf library works by serializing and then parsing a plan, without using any of the logic of substrait-python itself. Considering that it makes sense to remove the dependency on substrait-cpp, it makes sense to remove this file, which grabs the test files from substait-cpp. Furthermore, it isn't really testing anything within this library.
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
|
@EpsilonPrime yes it does, thanks for pointing that out. Will push a fix |
benbellick
changed the title
benbellick
changed the title
5 participants
Closes #99
Closes #98
BREAKING CHANGE: drop explicit support for JSON api