Fix TTS Reporting. #96
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the reporting of TTS (Time To Surface) on a number of dive computers. Report '0' (TTS not known) instead of an arbitrary number when building on Fedora. Signed-off-by: Michael Keller <github@ike.ch>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TTS (Time To Surface) reporting across multiple dive computer parsers by explicitly initializing the tts field to 0 when TTS data is not available, preventing arbitrary values from being reported due to uninitialized memory.
- Adds explicit
sample.deco.tts = 0initialization in Garmin and DeepSix parsers - Ensures consistent behavior across different platforms and compilers (specifically addressing Fedora build issues)
- Follows the established pattern used throughout the codebase where TTS=0 indicates "not known"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/garmin_parser.c | Adds TTS initialization to 0 for both DECOSTOP and NDL deco sample types where TTS data is not available from the device |
| src/deepsix_excursion_parser.c | Adds TTS initialization to 0 for all deco sample types (DECOSTOP, SAFETYSTOP, and NDL) in the v1 parser |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the reporting of TTS (Time To Surface) on a number of dive computers.
Report '0' (TTS not known) instead of an arbitrary number when building
on Fedora.
Signed-off-by: Michael Keller github@ike.ch