-
Notifications
You must be signed in to change notification settings - Fork 389
✨(buildpack) add PaaS deployment support, tested with Scalingo #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gunicorn -b :8000 impress.wsgi:application --log-file - & | ||
|
||
# Start the Y provider service | ||
cd src/frontend/servers/y-provider && PORT=4444 ../../.scalingo/node/bin/node dist/start-server.js & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: we should not hardcode the node binary path here.
FYI the same support was merged in Drive: suitenumerique/drive@dd6f0be |
@@ -0,0 +1,114 @@ | |||
# ERB templated nginx configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a configuration file specific to PAAS deployment. I think it should not be in the src
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have helm charts in src/ so I figured it was a good place for it... Where else would you put it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can create a build
or deploy
directory at the root project ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lunika a deploy
directory would make sense IMHO, could we also move files currently in docker
in there?
Hey @sylvinus ! |
This PR adds a new deployment option for Heroku-like platforms based on buildpacks, like Scalingo.
To deploy there, create a new app on one of these platforms, configure Postgres and Redis addons, and then add these configuration variables:
(Note that I'm using Scaleway's object storage and Zitadel's OIDC provider, you are free to use other services)
I'm still debugging a websocket issue but this should mostly work, testers welcome!
A few interesting links: