♿(frontend) add focus trap and enter key support to remove doc modal #1531
+70
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/a11y-modal-remove-doc-focus-trap
branch
from
70956fb to
34261f1
Compare
improves a11y by enabling keyboard-triggered modal with proper focus trap Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/a11y-modal-remove-doc-focus-trap
branch
from
34261f1 to
771de1c
Compare
|
Size Change: +255 B (+0.01%) Total Size: 3.68 MB
|
Ovgodd
added
bug
AntoLC
reviewed
Nov 6, 2025
Comment on lines
+97
to
+108
| const handleKeyDown = useCallback( | ||
| (event: KeyboardEvent<HTMLElement>, option: DropdownMenuOption) => { | ||
| if (event.key === 'Enter' || event.key === ' ') { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
| onOpenChange?.(false); | ||
| void option.callback?.(); | ||
| } | ||
| }, | ||
| [onOpenChange], | ||
| ); | ||
|
|
There was a problem hiding this comment.
You just created the hook useKeyboardAction, you should use it.
Comment on lines
+65
to
+66
| const cancelButton = document.getElementById(CANCEL_BUTTON_ID); | ||
| if (cancelButton instanceof HTMLButtonElement) { |
There was a problem hiding this comment.
I think it is better to use ref instead of an id or className in React.
Comment on lines
+64
to
+69
| useEffect(() => { | ||
| const cancelButton = document.getElementById(CANCEL_BUTTON_ID); | ||
| if (cancelButton instanceof HTMLButtonElement) { | ||
| cancelButton.focus(); | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
I don't understand the purpose of this useEffect, I don't see any changed when I comment this snippet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve accessibility and keyboard interactions for remove modal component
issue : 1530
Proposal
ModalRemoveDocuseKeyboardActionhook for Enter/Space handlers