💄(frontend) fine tuning emoji picker #1557
Open
+194
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
added
bug
|
Size Change: +175 B (0%) Total Size: 3.68 MB
|
AntoLC
force-pushed
the
enhance/fine-tuning-emoji-picker
branch
from
e729d45 to
bdf3182
Compare
AntoLC
changed the title
AntoLC
force-pushed
the
enhance/fine-tuning-emoji-picker
branch
2 times, most recently
from
c16f151 to
a0a500a
Compare
AntoLC
force-pushed
the
enhance/fine-tuning-emoji-picker
branch
2 times, most recently
from
30dbda1 to
9bd61e7
Compare
AntoLC
requested review from
Ovgodd and
lunika
and removed request for
lunika
- Add "Add Emoji" button to doc options menu - Remove default emoji when none selected - Improve doc options styling
With time some visual inconsistencies have crept into the DropButton and Icon component. This commit aims to harmonize the appearance with the design system.
When receiving a 401 error, we should set the auth query data to null, not to an object with user: null and authenticated: false. This ensures that components relying on the auth state can correctly interpret the unauthenticated status.
AntoLC
force-pushed
the
enhance/fine-tuning-emoji-picker
branch
from
9bd61e7 to
49cccb1
Compare
We simplify the way we handle different doc states (deleted / readonly) in the CSS, we avoid props drilling and are more component focused.
AntoLC
force-pushed
the
enhance/fine-tuning-emoji-picker
branch
from
49cccb1 to
e5581e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Integrate the review of @rl-83 about the emoji picker feature.
Proposal
Demo