feat: pull diagnostics #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let errors = diagnostics | ||
| .iter() | ||
| .filter(|d| d.severity() == Severity::Error) |
There was a problem hiding this comment.
There's also Severity::Fatal which would not be included here, should we maybe check d.severity() >= Severity::Error?
| impl<'a> JunitReporterVisitor<'a> { | ||
| pub(crate) fn new(console: &'a mut dyn Console) -> Self { | ||
| let report = Report::new("Biome"); | ||
| let report = Report::new("PgLsp"); |
Comment on lines
+38
to
+39
| // pub only: Vec<RuleSelector>, | ||
| // pub skip: Vec<RuleSelector>, |
There was a problem hiding this comment.
Should we remove those?
There was a problem hiding this comment.
we need them once the linter is there
Co-authored-by: Julian Domke <68325451+juleswritescode@users.noreply.github.com>
Co-authored-by: Julian Domke <68325451+juleswritescode@users.noreply.github.com>
Co-authored-by: Julian Domke <68325451+juleswritescode@users.noreply.github.com>
Co-authored-by: Julian Domke <68325451+juleswritescode@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds diagnostics
Copied and adapted from Biome. The CLI-related stuff will need some in-depth testing and a number of improvements eg to just handle sql files. I also do not know yet how to define a glob pattern. The
std-inmode is also not implemented yet. But the basics are working, and we will figure out the ergonomics later when the linter is implemented.checkcommandfor now just for syntax errors but it will be easily extendable. will add the linter after this.