fix(hover): hover multiple statements, hover table in policy/revoke/grant #500
+139
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
force-pushed
the
fix/various-hover-fixes
branch
from
333f8b3 to
48d9d4e
Compare
juleswritescode
force-pushed
the
fix/various-hover-fixes
branch
from
48d9d4e to
92b16fb
Compare
juleswritescode
changed the title
juleswritescode
commented
Sep 11, 2025
| @@ -742,7 +747,7 @@ impl Workspace for WorkspaceServer { | |||
| .next() | |||
| { | |||
| Some((stmt_id, range, ts_tree, maybe_ast)) => { | |||
| let position_in_stmt = params.position + range.start(); | |||
| let position_in_stmt = params.position - range.start(); | |||
There was a problem hiding this comment.
this led to errors when we had multiple statements in a file. Only the first could be hovered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.