fix: use global fetch instead of @supabase/node-fetch #1232
+3
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4w8n
reviewed
Jun 27, 2024
src/SupabaseClient.ts
Outdated
| @@ -100,7 +100,7 @@ export default class SupabaseClient< | |||
| this.headers, | |||
| settings.global.fetch | |||
| ) | |||
| this.fetch = fetchWithAuth(supabaseKey, this._getAccessToken.bind(this), settings.global.fetch) | |||
There was a problem hiding this comment.
Removing settings.global.fetch denies developers the ability to use a custom fetch, passed into the Supabase client's options.
|
HI @m-shaka ! Thank you so much for your contribution! I will not be merging this PR now. I will merge it once we officially drop support for Node 18, in October. I want to make sure we don't break any users early. That being said, I will add a reminder to merge your PR on November 1st! :D Again, thank you very much for your patience and for contributing to Supabase! |
mandarini
added
javascript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix #914
Additional context
As I posted here, this won't work on Node.js <18
#914 (comment)