refactor: improve state machines #744
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Break ClientHandler into more modules - Break ClientHandler into more states, with no arbitrary socket receives - Try to isolate some parts of ClientHandler: error handling, auth, etc - Remove dead code (read replicas) - Some refactoring/renaming, e.g.: db_pid -> db_connection (it was a tuple) - Logs and termination clean up - Use state enter for state tracking in ClientHandler (removes manual logger.metadata calls, adds telemetry)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
v0idpwn
force-pushed
the
refactor/improve-statems
branch
from
da5885d to
068393c
Compare
v0idpwn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.